This feature enables support for the L4 ILB Flex Ports feature currently available in alpha.

[modular-magician]

/cc @craigatgoogle

[danawillow]

@craigatgoogle, do you know whether the feature is in public alpha or whether the user has to be whitelisted? I don't love that none of our tests are going to cover this, but if it needs a whitelist then we'll need to get HashiCorp on the whitelist.

[craigdbarber]

Verified with the feature team that allPorts is available in public alpha. Added an acctest for the allPorts field, and in the process added a test template to MM for the ForwardingRule tests.

[danawillow]

Hey @craigatgoogle, this is what I got when running the new test:

------- Stdout: -------
=== RUN   TestAccComputeForwardingRule_allPorts
--- FAIL: TestAccComputeForwardingRule_allPorts (83.71s)
	testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
		
		* google_compute_forwarding_rule.foobar: 1 error(s) occurred:
		
		* google_compute_forwarding_rule.foobar: Error creating ForwardingRule: googleapi: Error 400: Invalid value for field 'resource.ports[0]': ''. Forwarding rules with backend services must specify at least one port., invalid
FAIL

[craigdbarber]

Spoke with @danawillow offline about the test issue, turned out to be due to the terraform generation script missing a section for resources utilizing the alpha APIs. Just pushed a fix for this to MM. An update to this PR should be inbound from Magician.

[danawillow]

Oh no, looks like a different PR in terraform modified tests that get copied over and so this is trying to overwrite them. Would you mind just doing these changes too in your PR so that we don't have to worry about merges and stuff?

[craigdbarber]

Happy to, although we should figure out who wrote that PR and let them know they should be doing those changes in MM for this resource going forward :)

[craigdbarber]

@emilymye with @danawillow OOO this week, would you mind finishing this review?

[emilymye]

It seems like this is the first alpha resource, and I have questions. The way the current provider works (i.e how URLs are decided), any users that were using forwarding rules will suddenly not be able to use their existing, non-alpha resources without asking to be whitelisted for the alpha APIs or downgrading Terraform. Is this what we expect, and if so...that seems non ideal. I don't think the alpha APIs are that easy to enable for users, but correct me if I am wrong. (cc @paddycarver and @danawillow @ndmckinley for when they are back)

The reason I ask this is because I actually don't have access to the alpha API in my current setup. Can you comment with the test result from your new test here?

Finally, this is less of a concern right now, but I'm a little worried about not adding send_empty_value: true in the api.yaml for MM. Right now it isn't an issue because ForceNew, but in the future, we might run into errors where setting to empty after it was set to true creates no-ops/permadiff hell.

[craigdbarber]

Here's the test results:

$ make testacc TESTARGS="--run TestAccComputeForwardingRule_allPorts"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v --run TestAccComputeForwardingRule_allPorts -timeout 120m
? github.com/terraform-providers/terraform-provider-google [no test files]
=== RUN TestAccComputeForwardingRule_allPorts
--- PASS: TestAccComputeForwardingRule_allPorts (117.02s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 117.255s
testing: warning: no tests to run
PASS
ok github.com/terraform-providers/terraform-provider-google/scripts 0.154s [no tests to run]

[emilymye]

So it turns out I didn't have the alpha SDK installed, which apparently also flips the flag for alpha compute. However, based on our offline discussion, @craigatgoogle is just going to wait for beta support. I'll approve for now but DO NOT MERGE until beta comes out.

[rileykarson]

Oh this is done! It went into beta. hashicorp/terraform-provider-google-beta#297

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!