Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Attachment support for Secure Web Proxy #18742

Conversation

modular-magician
Copy link
Collaborator

This PR adds the support for Secure Web Proxy (Gateway) on the Service Attachment resource.
This is provided on the field _ targetService_ which now will have support for the Forwarding Rule and the Secure Web Proxy (Gateway).

Note 1: Test scenario was needed to verify if it is working with SWP.

Note 2: Diff Suppress function was needed because the fields maybe be slightly different when using self_link and this will generate a change on the resource and break the test. For example:

OLD = "https://networkservices.googleapis.com/beta/projects/{PROJECT_ID}/locations/us-east1/gateways/{SWP_ID}"
NEW = "https://networkservices.googleapis.com/v1alpha1/projects/{PROJECT_ID}/locations/us-east1/gateways/{SWP_ID}"

Release Note Template for Downstream PRs (will be copied)

compute: changed `target_service` field on the `google_compute_service_attachment` resource to accept a `ForwardingRule` or `Gateway` URL.

Derived from GoogleCloudPlatform/magic-modules#11107

[upstream:8db8acdf91ee7da3edfcb272f23acd1e2623423c]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 14a7c44 into hashicorp:main Jul 16, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant