Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Remove unused dependencies #202

Merged
merged 2 commits into from
Jul 21, 2017
Merged

vendor: Remove unused dependencies #202

merged 2 commits into from
Jul 21, 2017

Conversation

radeksimko
Copy link
Member

This is probably just leftover from the initial provider split. 🤷‍♂️

@radeksimko radeksimko force-pushed the dep-remove-aws branch 2 times, most recently from 2bd21c1 to 9227330 Compare July 17, 2017 07:12
@radeksimko radeksimko mentioned this pull request Jul 17, 2017
Merged
catsby
catsby approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is probably good, can you document the command(s) you ran to come to this though?

@radeksimko
Copy link
Member Author

@catsby Basically as I was working my way through hashicorp/terraform#15562 and I ran through the vendor.json and saw some dependencies that made no sense to me at first sight. AWS being one of them, so I just dug deeper and tried to govendor remove each one I thought doesn't need to be there and then ran make test to see if I'm right or not.

I wish there was more sophisticated way to do this 🤷‍♂️

@radeksimko radeksimko merged commit c85c336 into master Jul 21, 2017
@radeksimko radeksimko deleted the dep-remove-aws branch July 21, 2017 09:45
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@radeksimko
Merge pull request hashicorp#202 from terraform-providers/dep-remove-aws
7344a4d 
vendor: Remove unused dependencies
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @rileykarson
Remove deprecated fields from Snapshot (hashicorp#202)
9a5f9b3 
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @catsby