Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google_project_iam_policy authoritative. #2280

Closed

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Oct 17, 2018

/cc @rileykarson
Part of #1167, #1203

@ghost ghost added the size/xl label Oct 17, 2018
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change here. Also unclear on how this fits in with #777.

}
}

func TestIamMergeBindings(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need this for _binding and _member? I thought they still merged things...

@modular-magician modular-magician force-pushed the codegen-pr-581 branch 2 times, most recently from 56bcf6c to 082f42d Compare October 19, 2018 18:34
@rileykarson
Copy link
Collaborator

This poor PR got orphaned by the Magician :(

Replaced with #2315

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
@modular-magician modular-magician deleted the codegen-pr-581 branch November 16, 2024 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants