Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regional cluster example #2385

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix regional cluster example #2385

merged 1 commit into from
Nov 12, 2018

Conversation

dkoston
Copy link
Contributor

@dkoston dkoston commented Nov 1, 2018

Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name

Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
@ghost ghost added the size/xs label Nov 1, 2018
@nat-henderson
Copy link
Contributor

This isn't a problem for me, but can you explain the difference?

@dkoston
Copy link
Contributor Author

dkoston commented Nov 7, 2018

It’s just an incorrect reference. primary is defined in the example above for non-regional and regional is defined in this example. If you copied and pasted the code and ran “terraform plan” it would error that primary is not defined or worse if you copied all the examples, you’d be referencing the non-regional cluster when you thought you were referencing the regional one.

@nat-henderson
Copy link
Contributor

Oh shoot! Thanks. :) You're right!

@rileykarson rileykarson merged commit 065128e into hashicorp:master Nov 12, 2018
rileykarson pushed a commit to rileykarson/terraform-provider-google that referenced this pull request Nov 12, 2018
Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
rileykarson added a commit to rileykarson/terraform-provider-google that referenced this pull request Nov 12, 2018
rileykarson pushed a commit that referenced this pull request Nov 13, 2018
Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
rileykarson added a commit that referenced this pull request Nov 13, 2018
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants