Fix disk type’Malformed URL’ error #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API expects the disk type to be a SelfLink URL, but the disk type name was being used (e.g. “pd-ssd”).
|
Please review @danawillow |
|
Thanks @sl1pm4t! Wish we had caught this with a test instead :-/ Mind adding (or modifying) a test that sets |
|
Sure thing @danawillow |
danawillow
reviewed
Aug 1, 2017
| zone = "us-central1-a" | ||
|
|
||
| boot_disk { | ||
| initialize_params { |
There was a problem hiding this comment.
Can you fix the indentation here? It should be tabs.
|
Oops - that test doesn't work. |
The Instance data does not contain the actual disk type, just "PERSISTENT". This commit uses the computeClient to pull the disk data from the API, allowing checking of the disk type. Also fmt'd the test configuration.
|
Thanks, looks good! |
z1nkum
pushed a commit
to z1nkum/terraform-provider-google
that referenced
this pull request
Aug 15, 2017
* Fix disk type’Malformed URL’ error The API expects the disk type to be a SelfLink URL, but the disk type name was being used (e.g. “pd-ssd”). * Add ACC Tests for boot disk type * Fix acceptance test & fmt test config The Instance data does not contain the actual disk type, just "PERSISTENT". This commit uses the computeClient to pull the disk data from the API, allowing checking of the disk type. Also fmt'd the test configuration.
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
* Fix disk type’Malformed URL’ error The API expects the disk type to be a SelfLink URL, but the disk type name was being used (e.g. “pd-ssd”). * Add ACC Tests for boot disk type * Fix acceptance test & fmt test config The Instance data does not contain the actual disk type, just "PERSISTENT". This commit uses the computeClient to pull the disk data from the API, allowing checking of the disk type. Also fmt'd the test configuration.
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
<!-- This change is generated by MagicModules. --> /cc @danawillow
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API expects the disk type to be a SelfLink URL, but the disk type
name was being used (e.g. “pd-ssd”). This resulted in the following error: