Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compute_network import #3087

Closed
wants to merge 1 commit into from
Closed

Conversation

cblecker
Copy link
Contributor

The import for compute_network was broken (the project wasn't being set on the resource, if the default provider project wasn't set).

This fixes it with a basic parser, so if you specific the project in the object import string, it will import.

This was done manually, as this resource isn't managed by MM.

@rileykarson rileykarson self-assigned this Mar 7, 2019
@rileykarson rileykarson self-requested a review March 7, 2019 16:55
@rileykarson
Copy link
Collaborator

Hey @cblecker! I'd had a PR to generate google_compute_network in Magic Modules in progress that I sent out superseding this; GoogleCloudPlatform/magic-modules#1489

Regardless, thanks for taking the time to send this PR! Sorry about not picking this up earlier.

@rileykarson rileykarson closed this Mar 8, 2019
@cblecker cblecker deleted the fix-network branch March 8, 2019 18:06
@cblecker
Copy link
Contributor Author

cblecker commented Mar 8, 2019

@rileykarson That's totally fine! I'm just glad to see this change in -- didn't have time to try and tackle the MM changes myself.

Thank you!

@ghost
Copy link

ghost commented Apr 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants