-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce exclusivity between org_id and folder_id for google_project #5064
Enforce exclusivity between org_id and folder_id for google_project #5064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Hi @bendrucker! Thanks for your contribution here. Unfortunately, this will be a breaking change, so we want to wait to merge it until our next major release. I will label this with our |
840fb82
to
6e61276
Compare
6e61276
to
05e5c00
Compare
Co-authored-by: Cameron Thornton <camthornton@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>
Clearing this from milestone given #5073 is already in it. Also, whoops, I picked up 5073 and missed this until sending my PR, so I'll likely close this and merge GoogleCloudPlatform/magic-modules#5323 instead. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
The documentation for
google_project
says:This adds
ConflictsWith
to declare this mutual exclusivity as part of the resource schema.