Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce exclusivity between org_id and folder_id for google_project #5064

Closed
wants to merge 2 commits into from
Closed

Enforce exclusivity between org_id and folder_id for google_project #5064

wants to merge 2 commits into from

Conversation

bendrucker
Copy link

The documentation for google_project says:

Only one of org_id or folder_id may be specified

This adds ConflictsWith to declare this mutual exclusivity as part of the resource schema.

@ghost ghost requested a review from paddycarver December 3, 2019 23:39
@ghost ghost added the size/xs label Dec 3, 2019
@ghost ghost requested a review from megan07 December 3, 2019 23:40
megan07
megan07 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@megan07
Copy link
Contributor

megan07 commented Dec 4, 2019

Hi @bendrucker! Thanks for your contribution here. Unfortunately, this will be a breaking change, so we want to wait to merge it until our next major release. I will label this with our breaking-change label and add it to our next milestone. Thanks again!

@megan07 megan07 added this to the 4.0.0 milestone Dec 4, 2019
@megan07 megan07 mentioned this pull request Dec 4, 2019
Closed
@paddycarver paddycarver removed their request for review December 17, 2019 00:58
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Aug 17, 2021
@modular-magician @c2thorn
Adding end-to-end example for L7 ILB (hashicorp#5064)
d01d836 
Co-authored-by: Cameron Thornton <camthornton@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this pull request Aug 17, 2021
@modular-magician @c2thorn
Adding end-to-end example for L7 ILB (#5064) (#9839)
93b5e56 
Co-authored-by: Cameron Thornton <camthornton@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Cameron Thornton <camthornton@google.com>
@ScottSuarez ScottSuarez self-assigned this Sep 28, 2021
@rileykarson rileykarson mentioned this pull request Oct 14, 2021
Merged
5 tasks
@rileykarson rileykarson removed this from the 4.0.0 milestone Oct 15, 2021
@rileykarson
Copy link
Collaborator

Clearing this from milestone given #5073 is already in it. Also, whoops, I picked up 5073 and missed this until sending my PR, so I'll likely close this and merge GoogleCloudPlatform/magic-modules#5323 instead.

This was referenced Oct 22, 2021
Merged
Merged
@bendrucker bendrucker closed this Nov 12, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@megan07 megan07 megan07 approved these changes

Assignees
No one assigned
Labels
breaking-change size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bendrucker @megan07 @rileykarson @ScottSuarez