Fix for the issue: #5381 : Check BGP ASN for RFC6996 compliance or be a value of 16550 #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new function to check if the ASN value provided during Cloud Router creation meets RFC6996 criteria or is 16550. Tested it on local deployment. Did not add a separate test case for ASN validation.
ghost
requested a review
from 
ankitvg
changed the title
nat-henderson
approved these changes
Jan 30, 2020
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Jan 30, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
added a commit
that referenced
this pull request
Jan 30, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue: #5381
Created a new function to check if the ASN value provided during Cloud Router creation meets RFC6996 criteria or is 16550.
Tested it on local deployment. Did not add a separate test case for ASN validation.