Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Postgres requiring user passwords #5569

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

s3bw
Copy link
Contributor

@s3bw s3bw commented Feb 3, 2020

As it's been noted this field is required on instances of Postgres: #4123 (comment)

This was previously changed since some instances don't require a password, and the documentation had to display the "lowest common level of validation".

the issue here is that Postgres instances require a password and will fail without one but MySql instances don't

Last updated: #1056

You'll notice in the debug output provided by the user in issue #4123 shows:

Missing user password for PostgreSQL instance

I think this PR might close issue 4123?

@ghost ghost requested review from rileykarson and nat-henderson February 3, 2020 14:05
@rileykarson rileykarson removed the request for review from nat-henderson February 3, 2020 20:49
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll upstream this so it gets applied to google-beta as well, then merge this PR.

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants