-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for upgrade_settings
in both node config and NAP config
#5676
Conversation
This fixes #5580. |
08397a1
to
ec74a29
Compare
@rileykarson @danawillow I'm still finishing up writing tests here, but had two quick questions:
EDIT: cc @slevenick @ndmckinley |
Additional context: |
This looks great.
In my opinion, no - I'd prefer it if you put it in
I think it's probably best to add this validation - our general approach is that validation is desirable unless it would impose an undue maintenance burden. In this case where the server-side can break if the validation isn't added, it seems extremely useful to add. |
Signed-off-by: Modular Magician <magic-modules@google.com>
Closing PR as stale |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
No description provided.