Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field requirements #5949

Closed
wants to merge 1 commit into from

Conversation

AmandaHassoun
Copy link
Contributor

Terraform apply was complaining that the project field was required, so updating the docs accordingly

Terraform apply was complaining that the project field was required, so updating the docs accordingly
@ghost ghost added the size/xs label Mar 23, 2020
@ghost ghost requested a review from emilymye March 23, 2020 14:37
@ghost ghost added the documentation label Mar 23, 2020
@emilymye
Copy link
Contributor

Hi @AmandaHassoun - while overall the project is required for creating the service account, it is optional on the resource because we allow for provider-default values. i.e. it's possible to do

provider "google" {
   project = "my-project"
}

resource  "google_service_account" {
    name = "my-sa-name"
}

where project isn't provided and thus optional for the service account.

I'm going to close this PR but feel free to re-open if you have other questions!

@emilymye emilymye closed this Mar 26, 2020
@AmandaHassoun
Copy link
Contributor Author

thanks @emilymye

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants