-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Go 1.13.4 -> 1.14.2 #6223
Conversation
@@ -24,4 +24,4 @@ require ( | |||
google.golang.org/api v0.22.0 | |||
) | |||
|
|||
go 1.13 | |||
go 1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping this to 1.14 does not prevent it from building with Go 1.13. Go 1.13.9+ will build it just fine.
The behavior of Go modules is still being tweaked with every compiler release. This directive simply instructs the compiler to use the latest behavior. It's a good idea to keep it up-to-date.
@@ -9,6 +9,7 @@ cloud.google.com/go/internal/version | |||
cloud.google.com/go/longrunning | |||
cloud.google.com/go/longrunning/autogen | |||
# cloud.google.com/go/bigtable v1.1.0 | |||
## explicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go mod vendor
added this 🤷♂️
Handing off to @megan07 since it's super relevant to the vendor removal work |
This PR has fallen behind |
Hey @y0ssar1an, there's a lot of things underway. That revert was due to a short test of the vendor removal changes. Please be patient :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This is a straightforward compiler version bump. All the tests passed with no issues. It's nice to finally delete this boilerplate.
Note that because it touches
vendor/modules.txt
there will be a merge conflict with #6219. It's easy to fix. When that merges, I'll simply rebase to deletevendor/
entirely.