Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bigquery connection with examples #6237

Conversation

modular-magician
Copy link
Collaborator

#5530

notes:

  1. it's unclear on if this is ga or not to me, the api url says beta, so i went with beta.
  2. I had to declare google-beta as the provider for everything in the examples, or the terraform go modules wouldn't build, what's the desired way to do this?
  3. name vs id was not clear to me, i mapped the properties directly from the api, but this leads to the oddly reading:
    instance_id = google_sql_database_instance.instance.connection_name
    per the docs, connection_id is optional (left blank a default is generated for you), which seems different from other products
  4. "DATABASE_TYPE_UNSPECIFIED" when set maps to an undefined value on response (the type property is not present in the response) - I couldn't find any code to cargo-cult here, suggestions?
`google_bigquery_connection`

Derived from GoogleCloudPlatform/magic-modules#3424

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Apr 28, 2020
@modular-magician modular-magician merged commit b96bdb2 into hashicorp:master Apr 28, 2020
emilymye pushed a commit that referenced this pull request Apr 29, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
emilymye pushed a commit that referenced this pull request Apr 30, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant