Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service is part of the URL and therefore is required. #6720

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/3720.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:breaking-change
`app_engine_flexible_app_version` and `app_engine_standard_app_version` now require `service` to be set. Before this change, leaving the value empty would have passed validation but failed during apply.

```
12 changes: 6 additions & 6 deletions google/resource_app_engine_flexible_app_version.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ replies to a healthcheck until it is ready to serve traffic. Default: "300s"`,
Required: true,
Description: `Desired runtime. Example python27.`,
},
"service": {
Type: schema.TypeString,
Required: true,
DiffSuppressFunc: compareSelfLinkOrResourceName,
Description: `AppEngine service resource`,
},
"api_config": {
Type: schema.TypeList,
Optional: true,
Expand Down Expand Up @@ -794,12 +800,6 @@ Please see the app.yaml reference for valid values at https://cloud.google.com/a
Optional: true,
Description: `The path or name of the app's main executable.`,
},
"service": {
Type: schema.TypeString,
Optional: true,
DiffSuppressFunc: compareSelfLinkOrResourceName,
Description: `AppEngine service resource`,
},
"serving_status": {
Type: schema.TypeString,
Optional: true,
Expand Down
12 changes: 6 additions & 6 deletions google/resource_app_engine_standard_app_version.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ All files must be readable using the credentials supplied with this call.`,
Required: true,
Description: `Desired runtime. Example python27.`,
},
"service": {
Type: schema.TypeString,
Required: true,
DiffSuppressFunc: compareSelfLinkOrResourceName,
Description: `AppEngine service resource`,
},
"automatic_scaling": {
Type: schema.TypeList,
Optional: true,
Expand Down Expand Up @@ -388,12 +394,6 @@ Modules API set_num_instances() you must use 'lifecycle.ignore_changes = ["manua
Description: `The version of the API in the given runtime environment.
Please see the app.yaml reference for valid values at https://cloud.google.com/appengine/docs/standard//config/appref`,
},
"service": {
Type: schema.TypeString,
Optional: true,
DiffSuppressFunc: compareSelfLinkOrResourceName,
Description: `AppEngine service resource`,
},
"threadsafe": {
Type: schema.TypeBool,
Optional: true,
Expand Down
8 changes: 4 additions & 4 deletions website/docs/r/app_engine_flexible_app_version.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@ The following arguments are supported:
(Required)
Health checking configuration for VM instances. Unhealthy instances are killed and replaced with new instances. Structure is documented below.

* `service` -
(Required)
AppEngine service resource


The `readiness_check` block supports:

Expand Down Expand Up @@ -311,10 +315,6 @@ The `liveness_check` block supports:
(Optional)
A service with manual scaling runs continuously, allowing you to perform complex initialization and rely on the state of its memory over time. Structure is documented below.

* `service` -
(Optional)
AppEngine service resource

* `project` - (Optional) The ID of the project in which the resource belongs.
If it is not provided, the provider project is used.

Expand Down
8 changes: 4 additions & 4 deletions website/docs/r/app_engine_standard_app_version.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ The following arguments are supported:
(Required)
Code and application artifacts that make up this version. Structure is documented below.

* `service` -
(Required)
AppEngine service resource


The `deployment` block supports:

Expand Down Expand Up @@ -220,10 +224,6 @@ The `files` block supports:
(Optional)
A service with manual scaling runs continuously, allowing you to perform complex initialization and rely on the state of its memory over time. Structure is documented below.

* `service` -
(Optional)
AppEngine service resource

* `project` - (Optional) The ID of the project in which the resource belongs.
If it is not provided, the provider project is used.

Expand Down