Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option 'all' for compute_firewall protocols as per #750 #7206

Closed
wants to merge 1 commit into from

Conversation

albertogeniola
Copy link

Fixes #750

Changes proposed in this pull request:

  • Added 'all' protocol option for compute_firewall resource

@ghost ghost added the size/xs label Sep 7, 2020
@ghost ghost requested a review from megan07 September 7, 2020 15:19
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @albertogeniola! Great catch! I had to find out what happened here, since it looked like we made the change here a while ago. It seems when we changed to generating code with the magician, the description wasn't updated where we generated from.
With that being said, would you be able to make this change in the https://github.com/GoogleCloudPlatform/magic-modules repo?
Specifically would you please make it at these spots for allow and deny?
If you want you can assign it to me and I can merge it ASAP.
Thanks again for your contribution, we appreciate it!

@albertogeniola
Copy link
Author

Hi @megan07 ,

done.

@megan07 megan07 closed this Sep 9, 2020
@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have firewall rule apply to all protocols, if specific protocol is omitted.
2 participants