Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp change to show to riley #7331

Closed
wants to merge 1 commit into from

Conversation

ScottSuarez
Copy link
Collaborator

No description provided.

@ghost ghost added size/m labels Sep 22, 2020
project, zone, instance.Name, ac.Name, networkName).Do()
if d.HasChange(prefix + ".subnetwork") {
if !d.HasChange(prefix + ".network") {
subnetProjectField := d.Get(prefix + ".subnetwork_project").(string)
Copy link
Collaborator

@rileykarson rileykarson Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just want to send in the prefix + .subnetwork_project string? This sends the field's value in where I thought the path to the field was expected.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! that's correct

@ScottSuarez ScottSuarez deleted the temp-cahnge branch September 23, 2020 18:45
@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants