Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MQL based alerting policies #7568

Closed
wants to merge 2 commits into from
Closed

Add MQL based alerting policies #7568

wants to merge 2 commits into from

Conversation

femnad
Copy link

@femnad femnad commented Oct 19, 2020

Fixes #7464

  • Names the key within the conditions block as condition_mql
  • Requires MQL queries to be in the strict form as they are sent verbatim.

@yegle
Copy link

yegle commented Oct 28, 2020

Ping @ScottSuarez we are looking to use MQL to define our alerts. Would it be possible to get this merged soon? Thank you!

@ScottSuarez
Copy link
Collaborator

Hi @yegle, this change is modifying auto generated code (check header) so this isn't something we'd be able to merge reasonably. If you want to look into making this change in our generator tool I could help review it there. Otherwise I could look at making this change manually there sometime next week.

@femnad
Copy link
Author

femnad commented Oct 28, 2020

I'm so sorry, that was a reading comprehension failure on my part, just created this PR instead: GoogleCloudPlatform/magic-modules/pull/4157. Closing this one.

Thanks very much!

@femnad femnad closed this Oct 28, 2020
@femnad femnad deleted the 7464-mql-based-alert-policies branch October 28, 2020 20:17
@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[resource/monitoring_alert_policy] Add support and docs example for MQL Alerting Policy
3 participants