Update CONTRIBUTING.md #7687
Closed
Update CONTRIBUTING.md #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `go env` to generate the expected folder structure.
ghost
added
the
ghost
requested a review
from 
c2thorn
reviewed
Nov 4, 2020
| @@ -91,8 +91,8 @@ Before using a local provider version, you'll need to set up [0.13+'s expected d | |||
| You can set up the directories required with the following commands. You should substitute your system's architecture or a different path if desired: | |||
|
|
|||
| ``` | |||
| mkdir -p ~/.terraform.d/plugins/registry.terraform.io/hashicorp/google/5.0.0/darwin_amd64 | |||
| mkdir -p ~/.terraform.d/plugins/registry.terraform.io/hashicorp/google-beta/5.0.0/darwin_amd64 | |||
| mkdir -p ~/.terraform.d/plugins/registry.terraform.io/hashicorp/google/5.0.0/$(go env GO_HOSTOS)_$(go env GOHOSTARCH) | |||
There was a problem hiding this comment.
Can we leave the example darwin_amd64 and offer the go env method as an option? potentially in the sentence above where we explain substituting the system's architecture
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Apr 13, 2023
…oss_prevention_job_trigger (hashicorp#7687) * Added job_notification_emails and deidentify actions in google_data_loss_prevention_job_trigger * Updated the deidentify actions enum and added update tests for deidentify action Signed-off-by: Modular Magician <magic-modules@google.com>
|
Closing PR as stale |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
go envto generate the expected folder structure.