Refactored authoritative IAM policy logic to be reusable #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- PASS: TestAccGoogleFolderIamPolicy_basic (16.82s)
--- PASS: TestAccGoogleFolderIamPolicy_update (20.12s) |
rosbo
force-pushed
the
iam-folder-policy-refactor
branch
from
0899026 to
720ae93
Compare
danawillow
approved these changes
Nov 21, 2017
google/iam_folder.go
Outdated
| } | ||
|
|
||
| func (u *FolderIamUpdater) GetMutexKey() string { | ||
| return fmt.Sprintf("iam-project-%s", u.folderId) |
google/iam_folder.go
Outdated
| } | ||
|
|
||
| func (u *FolderIamUpdater) DescribeResource() string { | ||
| return fmt.Sprintf("project %q", u.folderId) |
google/iam_folder.go
Outdated
| out := &resourceManagerV2Beta1.Policy{} | ||
| err := Convert(in, out) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("Cannot convert a v1 oolicy to a v2beta policy: %s", err) |
google/iam_folder.go
Outdated
| out := &cloudresourcemanager.Policy{} | ||
| err := Convert(in, out) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("Cannot convert a v2beta oolicy to a v1 policy: %s", err) |
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the work I did for IAM binding and member resources in #744.
Could not reuse it for project because of the deprecated
authoritativeboolean field. Once we bump the version and remove the deprecated field in project, we can reuse the same logic. I created an issue to track this work once the field is removed #777.