Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Adds new restore_policy on google_project_default_service_accounts #7768

Merged
merged 4 commits into from
Nov 30, 2020
Merged

Feature: Adds new restore_policy on google_project_default_service_accounts #7768

merged 4 commits into from
Nov 30, 2020

Conversation

thiagonache
Copy link
Contributor

@thiagonache thiagonache commented Nov 10, 2020 •
edited
Loading

Adds new restore_policy REVERT_AND_IGNORE_FAILURE in order to ignore the errors returned on the revert during the resource destroy

@thiagonache
Adds new restore policy REVERT_AND_IGNORE_FAILURE in order to ignore …
0fdb83f 
…errors returned on the revert during the resource destroy
@ghost ghost added the size/xs label Nov 10, 2020
@ghost ghost requested review from slevenick and nat-henderson November 10, 2020 01:46
@thiagonache thiagonache mentioned this pull request Nov 10, 2020
Merged
@thiagonache
Adds new test for new restore policy. This function should not check …
a4ed5d8 
…revert because the policy says to ignore. I have injected an error on the undelete function to simulate API error and it worked as expected. Worth to mention that on day to day it is just testing it overall behavior when the restore_policy is REVERT_AND_IGNORE_FAILURE
@ghost ghost added size/s and removed size/xs labels Nov 10, 2020
@thiagonache thiagonache marked this pull request as ready for review November 10, 2020 02:56
@morgante morgante mentioned this pull request Nov 11, 2020
Merged
@thiagonache
Copy link
Contributor Author

@ndmckinley @slevenick friendly ping about this PR.

slevenick
slevenick requested changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@slevenick slevenick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Can you update the markdown doc for this file to include information on REVERT_AND_IGNORE_FAILURE?

https://github.com/hashicorp/terraform-provider-google/blob/master/website/docs/r/google_project_default_service_accounts.html.markdown

google/resource_google_project_default_service_accounts.go Outdated Show resolved Hide resolved
google/resource_google_project_default_service_accounts.go Outdated Show resolved Hide resolved
@thiagonache
Copy link
Contributor Author

the job error seems unrelated. I've not changed any weblinks and the existing ones are working.

@thiagonache
Copy link
Contributor Author

Running locally I got no errors:

Found no broken links.

FINISHED --2020-11-25 10:01:37--
Total wall clock time: 1m 16s
Downloaded: 415 files, 48M in 0.9s (56.6 MB/s)
tf-website-google-temp

@slevenick slevenick mentioned this pull request Nov 25, 2020
Merged
5 tasks
slevenick
slevenick approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slevenick slevenick merged commit 99a1311 into hashicorp:master Nov 30, 2020
This was referenced Nov 30, 2020
Merged
Merged
@bharathkkb bharathkkb mentioned this pull request Dec 3, 2020
Closed
@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
@thiagonache thiagonache deleted the feature/gpdsa_revert_and_ignore_restore_policy branch June 6, 2023 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slevenick slevenick slevenick approved these changes

@nat-henderson nat-henderson Awaiting requested review from nat-henderson

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagonache @slevenick