WIP: Ability to add/remove node pools from a GKE cluster #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly works, with several large caveats:
As such, I'm not looking for feedback now, but putting this out there just as a "hey I'm working on this" PR, and also so that nobody ends up duplicating this work.
The real solution for the first point is to convert
node_pool
into a set. The rest I could hypothetically fix now, but I'm going to hold off on new changes until node pools are a Set.