Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Ability to add/remove node pools from a GKE cluster #779

Closed
wants to merge 1 commit into from

Conversation

danawillow
Copy link
Contributor

This mostly works, with several large caveats:

  • You can't add a node pool in the middle of a list, only at the end
  • Name prefixes / empty names don't work as expected
  • I haven't written any test cases yet, just manual ones

As such, I'm not looking for feedback now, but putting this out there just as a "hey I'm working on this" PR, and also so that nobody ends up duplicating this work.

The real solution for the first point is to convert node_pool into a set. The rest I could hypothetically fix now, but I'm going to hold off on new changes until node pools are a Set.

@rileykarson
Copy link
Collaborator

Is this outdated @danawillow?

@danawillow
Copy link
Contributor Author

Ah yes very. I'll probably update again later with all the reasons why this is a bad idea, but I'll go ahead and close it for now.

@danawillow danawillow closed this Nov 15, 2018
@rileykarson
Copy link
Collaborator

Sounds good! #780 is probably a better home for updates, I think you pointed to it from #1712 as well.

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants