Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tier setting to use db-f1-micro #783

Closed
wants to merge 1 commit into from

Conversation

nathanleclaire
Copy link

The existing setting of "D0" caused an error for me when running
terraform apply. This fixes the issue and allows the apply to proceed.

ping @danawillow

The existing setting of "D0" caused an error for me when running
`terraform apply`. This fixes the issue and allows the apply to proceed.
@nathanleclaire
Copy link
Author

And thanks for the work on this integration btw!

@danawillow
Copy link
Contributor

Ok, so there are a few things going on here.

  • The example is just bad generally because it doesn't provide a region, which is a required field.
  • v1 vs v2 databases live in different regions: https://cloud.google.com/sql/docs/mysql/instance-locations. The error you got was likely because you tried to create it in a region that only supports second-gen instances (apologies for the bad error message, I just reported it to the team)
  • Changing the tier will just cause the same issue for different regions

So instead of this change, let's have two separate examples- one for a v1 database (tier D0), and another for a v2 database (tier db-f1-micro). And each one can set the region to something that's valid for that tier. We should probably also have more fleshed-out examples in general (instead of one that's just required fields), but we can do that another day if you don't feel like doing it now.

How does this sound, @nathanleclaire?

@nathanleclaire
Copy link
Author

Sure, sounds good. You want me to update this PR to have the two examples you mention?

@danawillow
Copy link
Contributor

If you don't mind, that would be great!

@rosbo
Copy link
Contributor

rosbo commented Feb 19, 2018

The documentation was updated in #1066 to include two examples. One for 1st gen and one for the 2nd gen.

Thanks for flagging this.

@rosbo rosbo closed this Feb 19, 2018
@nathanleclaire
Copy link
Author

Thanks @rosbo , I dropped the 🏀 on this one!

@nathanleclaire nathanleclaire deleted the db_tier branch February 20, 2018 19:29
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants