Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct import directions #8108

Closed
wants to merge 2 commits into from

Conversation

AdrienneCohea
Copy link

@AdrienneCohea AdrienneCohea commented Jan 3, 2021

I believe that the documentation might be incorrect, or the behavior of the API changed. It appears that location must be provided. I tried to import with terraform import google_kms_crypto_key.worker_auth asgard-boundary/worker-auth and encountered the error:

Error: Invalid CryptoKey id format, expecting `{projectId}/{locationId}/{KeyringName}/{cryptoKeyName}` or `{locationId}/{keyRingName}/{cryptoKeyName}, got id: asgard-boundary/worker-auth`

By prepending location according to the directions from the error, I achieved the desired import.

@ghost ghost added size/xs labels Jan 3, 2021
@ghost ghost requested a review from nat-henderson January 3, 2021 22:48
@AdrienneCohea AdrienneCohea marked this pull request as ready for review January 3, 2021 23:09
@AdrienneCohea
Copy link
Author

I believe that the failing checks are not due to my change.

@nat-henderson
Copy link
Contributor

Thanks! This is generated code - would you be interested in making this change in the generator - github.com/GoogleCloudPlatform/magic-modules - instead? It's handled here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/kms/terraform.yaml. If not, can you open an issue in this repository and we'll handle it?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants