Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose filtered CIDRs ranges for default domains #9326

Closed
wants to merge 1 commit into from

Conversation

bpineau
Copy link
Contributor

@bpineau bpineau commented Jun 8, 2021

Per https://cloud.google.com/vpc/docs/configure-private-google-access#ip-addr-defaults :

The IP addresses used by the default domains for Google APIs and services fit within
the list of ranges computed by taking away all ranges in cloud.json from those in
goog.json. The following example shows you how to get this range using Python.

terraform-provider-google was offering access to both goog.json
(google-netblocks) and cloud.json (cloud-netblocks) but not to
that useful subset of addresses in goog.json but not in cloud.json,
which is hard to process otherwise (using only terraform native transforms).

This mirrors the above doc's python script's behavior.

The "default domains" name comes straight from the documentation linked above,
but I'm not sure if that the best choice here?

@bpineau bpineau changed the title Exposes filtered CIDRs ranges for default domains Expose filtered CIDRs ranges for default domains Jun 8, 2021
@bpineau bpineau force-pushed the bp/default-domains-ranges branch from c56f00a to 58f3dce Compare June 8, 2021 16:12
Per https://cloud.google.com/vpc/docs/configure-private-google-access#ip-addr-defaults :

> The IP addresses used by the default domains for Google APIs and services fit within
> the list of ranges computed by taking away all ranges in cloud.json from those in
> goog.json. The following example shows you how to get this range using Python.

`terraform-provider-google` was offering access to both `goog.json`
(`google-netblocks`) and `cloud.json` (`cloud-netblocks`) but not to
that useful subset of addresses in goog.json but not in cloud.json,
which is hard to process otherwise (using only terraform native transforms).

This mirrors the above doc's python script's behavior.
@slevenick
Copy link
Collaborator

This looks pretty good! The only thing I'm hesitant about is adding the dependency on another repo.

Is there a way to replicate that behavior without the external dependency? If not I'll likely approve this, but it will take me a little bit to upstream to preserve it between this repo and the beta provider

@joshuagibeonm
Copy link

Hi, Is there any follow up for this PR? We stumbled across a problem that requires set of filtered CIDRs ranges for GCP default domains.

If needed, I would like to provide support that needed to make this PR accepted.

Looking at the dependency that needed for this PR, it looks like https://github.com/go-netaddr/netaddr is not maintained anymore?

@slevenick
Copy link
Collaborator

No follow up, and I'm going to close this PR for now as it's been so long. My only concern for this PR in general was the dependency, and we probably shouldn't use it if it's not maintained.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants