Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit support for KUBECONFIG #604

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Remove implicit support for KUBECONFIG #604

merged 2 commits into from
Oct 13, 2020

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Oct 13, 2020

Description

This PR removes implicit support for the KUBECONFIG environment variable. See hashicorp/terraform-provider-kubernetes#909 for context on this change.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

See github action output.

Release Note

Release note for CHANGELOG:

Remove implicit support for `KUBECONFIG` environment variable.

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team October 13, 2020 19:41
@@ -196,12 +191,6 @@ func kubernetesResource() *schema.Resource {
DefaultFunc: schema.EnvDefaultFunc("KUBE_TOKEN", ""),
Description: "Token to authenticate an service account",
},
"load_config_file": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP 💀

@jrhouston jrhouston merged commit 28dafca into master Oct 13, 2020
@jrhouston jrhouston deleted the v2-kubeconfig branch October 13, 2020 19:57
@ghost
Copy link

ghost commented Nov 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants