Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up matrix build to run acc tests against different tf versions #637

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

jrhouston
Copy link
Contributor

Description

This PR adds a matrix build to run the acceptance tests against 0.12, 0.13, and 0.14. We could probably script further to pull the latest versions from the CDN or git tags but for now its hard coded.

@ghost ghost added the size/XS label Dec 1, 2020
@jrhouston jrhouston changed the title Set up matric build to run acc tests against different tf versions Set up matrix build to run acc tests against different tf versions Dec 1, 2020
@jrhouston jrhouston requested a review from aareet December 1, 2020 16:30
@aareet
Copy link
Contributor

aareet commented Dec 1, 2020

@jrhouston there's a deprecation in Github Actions that's fixed in setup-kind v0.5.0 - https://github.com/engineerd/setup-kind/releases. I made a PR #635 for the upgrade, but it was blocked on the fix for the stable repo deprecation. Feel free to do it in here instead.

@aareet
Copy link
Contributor

aareet commented Dec 8, 2020

Depends on #638

@jrhouston jrhouston force-pushed the acc-test-matrix branch 2 times, most recently from 2f855ea to f8853a9 Compare December 9, 2020 03:19
@jrhouston jrhouston merged commit 1fa1e7b into master Dec 9, 2020
@jrhouston jrhouston deleted the acc-test-matrix branch December 9, 2020 03:29
@ghost
Copy link

ghost commented Jan 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants