Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kubernetes config check out of providerConfigure #648

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Dec 19, 2020

Description

This PR moves the logic to check that the kubernetes config for the provider is not empty from providerConfigure() to GetHelmConfiguration() which gets called later. Doing this early was triggering the progressive apply issue.

Fixes #647

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

See GitHub Actions output.

Release Note

Release note for CHANGELOG:

Fix error when using outputs from another resource in the provider block

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/XS labels Dec 19, 2020
@aareet aareet self-requested a review December 19, 2020 20:11
@aareet
Copy link
Contributor

aareet commented Dec 19, 2020

Not sure how yet but maybe later we can add some sort of regression test with the kind provider to test this regularly. Not required for this to merge.

@jrhouston
Copy link
Contributor Author

Yeah, I managed to craft a config using modules that reproduces the issue locally without provisioning a cluster on a cloud provider so we should be able to write a test to trigger this case. I agree that we should hotfix this first then add the test in another PR – I'll open an issue to capture.

@jrhouston jrhouston merged commit 9de5e32 into master Dec 19, 2020
@jrhouston jrhouston deleted the fix-config-check-pgapply branch December 19, 2020 21:19
@ghost
Copy link

ghost commented Jan 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring provider using another resource's outputs is not possible anymore since v2.0.0
2 participants