Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply interactiveMode when using exec plugins #798

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

jrhouston
Copy link
Contributor

Description

Fixes #797

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Fix exec plugin interactive mode regression

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'm wondering if there are any plugins out there which require the "Always" setting. Let's keep an eye out for those - we might need to keep track of them in the provider, or just expose this setting to the user.

@jrhouston
Copy link
Contributor Author

LGTM. I'm wondering if there are any plugins out there which require the "Always" setting. Let's keep an eye out for those - we might need to keep track of them in the provider, or just expose this setting to the user.

They simply wouldn't be able to use them at present – Terraform doesn't have a way of surfacing stdin from a subprocess of a provider to the user AFAIK.

@jrhouston jrhouston merged commit ff039c3 into main Nov 9, 2021
@jrhouston jrhouston deleted the interactive-mode branch November 9, 2021 18:45
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exec plugin auth seems broken in 2.4.0
2 participants