Always use latest repository credentials #846
Conversation
Read and delete operations do not require access to the actual chart, so we don't need to login. Removing this prevents issues on refresh for short-living, rotated credentials as e.g. used by Amazon ECR.
|
|
|
@jrhouston Since you wrote the original PR for this, could you maybe check this one? Maybe I missed some reason for why you added the logins to the places that I removed them from. |
|
Yep, you're right @mKeRix – logging into the OCI registry is unnecessary in these places as we only need to login when creating or updating the release. |
|
@jrhouston I see you've mentioned tag |
|
@junaid-ali The release should be out now. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Read and delete operations do not require access to the actual chart, so we don't need to login for those. In the current implementation any refresh fails if the credentials used in the past expire, e.g. when you use the resource with rotating Amazon ECR credentials. If you only do the login in the operations that actually pull a chart (create & update), the resource will always use the most recent credentials for its operations.
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Closes #844
Community Note