Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCI registry login concurrency issue #848

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Apr 6, 2022

The provider should log into each registry only once. I've added a mutex here so that parallel login attempts don't interfere with each other.

I've also added a test case which spins up a passworded OCI registry and uses it to create multiple releases.

Fixes #845

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Fix OCI registry concurrent login issue 

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

The provider should log into each registry only once. I've added
a mutex here so that parallel login attempts don't interfere with
each other.
@github-actions github-actions bot added the size/M label Apr 6, 2022
@jrhouston jrhouston force-pushed the oci-login-concurrency branch 2 times, most recently from c9e3392 to d7d8cca Compare April 10, 2022 19:20
@github-actions github-actions bot added size/L and removed size/M labels Apr 10, 2022
@jrhouston jrhouston force-pushed the oci-login-concurrency branch from d7d8cca to 720a00c Compare April 10, 2022 19:29
@jrhouston jrhouston merged commit 9d162fb into main Apr 10, 2022
@jrhouston jrhouston deleted the oci-login-concurrency branch April 10, 2022 19:42
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI: The specified item already exists in the keychain
1 participant