Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post renderer args #869

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Add post renderer args #869

merged 6 commits into from
Jun 7, 2022

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jun 2, 2022 •
edited
Loading

Description

Added args attribute for post-render as part of new feature implemented in Helm v3.9.0

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

* Add args attribute in post-render block

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

jrhouston
jrhouston requested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for adding this @Bbmau – couple small things.

website/docs/r/release.html.markdown Outdated Show resolved Hide resolved
helm/resource_release.go Outdated Show resolved Hide resolved
BBBmau added 2 commits June 6, 2022 20:51
@BBBmau
Update release.html.markdown
331cbd0 
update to args description
@BBBmau
Update resource_release.go
d4dda46 
format to match other similar lines
@BBBmau BBBmau merged commit bea9c64 into main Jun 7, 2022
@BBBmau BBBmau deleted the add-post-renderer-args branch June 7, 2022 03:58
@BBBmau BBBmau restored the add-post-renderer-args branch June 7, 2022 16:39
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrhouston jrhouston jrhouston requested changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BBBmau @jrhouston