Fix Unknown Value in Manifest Diff #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhouston
force-pushed
the
fix-Unknown-Manifest
branch
2 times, most recently
from
2deb15b to
69a7578
Compare
|
Thanks for opening this @BBBmau. I've pushed a regression test to this branch. If you uncomment the fix and run that test you'll see it catches the bug described in the original issue. |
jrhouston
force-pushed
the
fix-Unknown-Manifest
branch
from
69a7578 to
cf385d2
Compare
jrhouston
approved these changes
Oct 11, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #965
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note