Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm_template codeblock #995

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Update helm_template codeblock #995

merged 1 commit into from
Nov 17, 2022

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Nov 14, 2022

Description

Fixes #984

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from arybolovlev November 14, 2022 23:45
arybolovlev
arybolovlev approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍🏻

@BBBmau BBBmau merged commit 8f396c4 into main Nov 17, 2022
@BBBmau BBBmau deleted the fix-template-docs branch November 17, 2022 16:07
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
documentation pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm_template doc samples point to the templates field but it should be show_only
2 participants
@BBBmau @arybolovlev