Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.33.0 #2600

Merged
merged 1 commit into from
Oct 11, 2024
Merged

v2.33.0 #2600

merged 1 commit into from
Oct 11, 2024

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Oct 10, 2024

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner October 10, 2024 19:41
JaylonmcShan03
JaylonmcShan03 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)!

@BBBmau BBBmau merged commit 46c8c2a into hashicorp:main Oct 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appilon appilon appilon approved these changes

@JaylonmcShan03 JaylonmcShan03 JaylonmcShan03 approved these changes

Assignees
No one assigned
Labels
pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BBBmau @appilon @JaylonmcShan03