-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ephemeral resources: kubernetes_token_request_v1
, kubernetes_certificate_signing_request_v1
#2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhouston
force-pushed
the
ephemeral-resources-dev
branch
from
November 21, 2024 03:04
740dc90
to
00acd33
Compare
appilon
reviewed
Nov 21, 2024
internal/framework/provider/authenticationv1/ephemeral_token_request_v1.go
Show resolved
Hide resolved
appilon
reviewed
Nov 21, 2024
internal/framework/provider/authenticationv1/ephemeral_token_request_v1.go
Show resolved
Hide resolved
appilon
previously approved these changes
Nov 21, 2024
jrhouston
force-pushed
the
ephemeral-resources-dev
branch
from
November 25, 2024 17:30
37d436b
to
01b566e
Compare
BBBmau
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for ephemeral resources, introducing ports of the
kubernetes_token_request_v1
andkubernetes_certificate_signing_request_v1
resources to ephemeral resources.Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note