This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Don't configure proxy from env twice #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
The proxy env vars are already taken into consideration here https://github.com/terraform-providers/terraform-provider-mysql/blob/master/mysql/provider.go#L152 Setting them as default for `proxy` leads to the proxy being set as proxy itself and as forwarder (see https://github.com/terraform-providers/terraform-provider-mysql/blob/master/mysql/provider.go#L160). This leads to the following error (with `all_proxy=socks5://127.0.0.1:1080`) Could not connect to server: socks connect tcp localhost:1080->target_host:target_port: socks connect tcp localhost: 1080->localhost: 1080
pascal-hofmann
force-pushed
the
patch-1
branch
from
b8650a4
to
66adad4
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy env vars are already taken into consideration here https://github.com/terraform-providers/terraform-provider-mysql/blob/master/mysql/provider.go#L152
Setting them as default for
proxyleads to the proxy being set as proxy itself and as forwarder (see https://github.com/terraform-providers/terraform-provider-mysql/blob/master/mysql/provider.go#L160).This leads to the following error (with
all_proxy=socks5://127.0.0.1:1080)