This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Fix feature detection between MySQL and MariaDB #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
spawnia
changed the title
spawnia
commented
Feb 11, 2020
| return parseServerVersionString(versionString), nil | ||
| } | ||
|
|
||
| func (serverVersion ServerVersion) supportsRoles() bool { |
There was a problem hiding this comment.
Those helpers could receive db *sql.DB as well, that might simplify their usage.
What i like about this version is that it would enable a performance optimization: We could query for the version once and use that single result throughout all functions that need it.
spawnia
commented
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
I generalized the way that feature detection is performed to ensure it works correctly with MariaDB.