This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Add CA param #99
Open
Add CA param #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I was contemplating implementing this, with one difference, I would have the CA param accept the contents of the file. This way it can be read from different resources/data not just local files and passed to this. |
|
Nice suggestion. I added it to the recently commited changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help fix issue #98.
I'm a Go noob, so if there are any styling/logic issues, please point them out.
This works by changing the
tlsconfig option given to the MySql client to"custom"if the ssl_ca parameter is defined. This effectively allows a different tls configuration to be used, as defined in the go-sql-driver docs. This new configuration specifies a set of CA certificates and skips issuer verification depending on the originaltlsparameter being "skip-verify".