Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update terraform SDK to 2.4.0 and Nomad to 1.0.2 #166

Merged
merged 12 commits into from
Jan 16, 2021
Merged

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Oct 30, 2020

also, updated to 2.1.0 SDK. this caused a bunch of errors in the provider to become apparent, so we cleaned those up. numerous fields listed in the schema were never actually set, and have been removed.

@cgbaker cgbaker marked this pull request as draft October 30, 2020 21:47
@cgbaker cgbaker requested a review from lgfa29 October 30, 2020 21:47
@cgbaker cgbaker marked this pull request as ready for review October 30, 2020 21:47
@lgfa29 lgfa29 changed the title update terraform SDK to 2.1.0 update terraform SDK to 2.4.0 and Nomad to 1.0.1 Jan 14, 2021
lgfa29
lgfa29 previously approved these changes Jan 14, 2021
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I update the SDK version to 2.4.0 since this PR has been waiting for review for a while. I also updated Nomad to 1.0.1.

I also ran a quick test to make sure that the changes to the nomad_job resource wouldn't impact existing jobs. I used the Nomad E2E test suite but deployed the jobs using TF with the current released version of the provider (1.4.11).

I then updated my config to use a custom build from this PR and ran terraform apply again. There were no significant differences between in the state diff.

One group disappeared, but I think that was part of the test, and one volume switched from read_only = true to read_only = false, but I think that's because my environment didn't have the specific CSI plugin properly setup. Other volumes kept their read_only state.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this one for now because it modifies the schema of mount_options in nomad_volume in a way that will conflict with #188

@lgfa29 lgfa29 changed the title update terraform SDK to 2.4.0 and Nomad to 1.0.1 update terraform SDK to 2.4.0 and Nomad to 1.0.2 Jan 15, 2021
lgfa29
lgfa29 previously approved these changes Jan 15, 2021
@lgfa29 lgfa29 merged commit 2d6a2ba into master Jan 16, 2021
@lgfa29 lgfa29 deleted the f-update-terraform-sdk branch January 16, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants