resource/external_volume: fix mount flags parsing #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mount flags parsing tries to cast directly to a slice of strings, but this silently fails and leaves us with empty mount flags.
tgross
force-pushed
the
csi-mount-flags-parsing
branch
from
f927c1c
to
ff7e534
Compare
lgfa29
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Thanks @tgross!
There's definitely a little bit of art in writing Terraform tests, and this resource didn't have any since it requires a cluster with CSI configured.
I added some basic testing based on the hostpath demo since it's fairly easy to get it running locally with Vagrant.
Though I don't think they will be able to run in CI since it requires privileged Docker access. I will give it a try in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
The mount flags parsing tries to cast directly to a slice of strings,
but this silently fails and leaves us with empty mount flags.
I've tested this manually but I need to brush up on how to write Terraform tests because I don't quite understand how it's working in this repo. Putting the PR up for review while I work on that.