This repository has been archived by the owner on Nov 30, 2018. It is now read-only.
Rename environment to workspace. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
suggested changes
Sep 5, 2017
There was a problem hiding this comment.
Hi @caiges
thanks for taking time to craft the PR. This change makes sense. The only thing I'm worried about is that it's a breaking change. Do you mind keeping the old field in place and marking it as Deprecated instead?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up with the recent rename from environments to workspaces. I was initially confused when I tried to use
workspacewithterraform_remote_stateand it failed. Looking at the docs showed they were still referencingenvironment, this PR corrects that behavior and documentation.