Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test for resource_private_key_test #140

Conversation

dttung2905
Copy link

Hi team,

I would like to put forward this MR to fix the error when running make test.

❯ make test
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./...) || exit 1
echo $(go list ./...) | \
        xargs -t -n4 go test  -timeout=120s -parallel=4
go test '-timeout=120s' '-parallel=4' github.com/terraform-providers/terraform-provider-tls github.com/terraform-providers/terraform-provider-tls/internal/provider 
?       github.com/terraform-providers/terraform-provider-tls   [no test files]
--- FAIL: TestPrivateKeyRSA (0.25s)
    resource_private_key_test.go:13: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Output refers to sensitive values
        
          on terraform_plugin_test.tf line 5:
           5:                     output "private_key_pem" {
        
        To reduce the risk of accidentally exporting sensitive data that was intended
        to be only internal, Terraform requires that any root module output
        containing sensitive data be explicitly marked as sensitive, to confirm your
        intent.
        
        If you do intend to export this data, annotate the output value as sensitive
        by adding the following argument:
            sensitive = true
--- FAIL: TestPrivateKeyECDSA (0.26s)
    resource_private_key_test.go:108: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Output refers to sensitive values
        
          on terraform_plugin_test.tf line 5:
           5:                     output "private_key_pem" {
        
        To reduce the risk of accidentally exporting sensitive data that was intended
        to be only internal, Terraform requires that any root module output
        containing sensitive data be explicitly marked as sensitive, to confirm your
        intent.
        
        If you do intend to export this data, annotate the output value as sensitive
        by adding the following argument:
            sensitive = true
FAIL
FAIL    github.com/terraform-providers/terraform-provider-tls/internal/provider 22.610s
FAIL
make: *** [GNUmakefile:12: test] Error 123

@detro
Copy link
Contributor

detro commented Mar 11, 2022

This was closed by #153

Thank you

@detro detro closed this Mar 11, 2022
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants