-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of the Targets body schema field for modules #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-goto-local-module-source
branch
3 times, most recently
from
April 5, 2022 12:01
c72951a
to
37d0e87
Compare
dbanck
changed the title
Make use of the LinksTo body schema field for modules
Make use of the Targets body schema field for modules
Apr 5, 2022
dbanck
force-pushed
the
f-goto-local-module-source
branch
2 times, most recently
from
April 5, 2022 13:27
eb60b2c
to
6abad45
Compare
radeksimko
suggested changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor naming suggestion - otherwise LGTM.
earlydecoder now collects a sorted list of filenames for each module
The target will point to the first file of a module
dbanck
force-pushed
the
f-goto-local-module-source
branch
from
April 6, 2022 12:19
6abad45
to
40b4520
Compare
radeksimko
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the earlydecoder to store the list of filenames inside a module. We then use the list of filenames to select a target for the body schema.
Depends on hashicorp/hcl-lang#112
Required for hashicorp/terraform-ls#558