Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the Targets body schema field for modules #101

Merged
merged 6 commits into from
Apr 6, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Apr 1, 2022

This PR extends the earlydecoder to store the list of filenames inside a module. We then use the list of filenames to select a target for the body schema.

Depends on hashicorp/hcl-lang#112

Required for hashicorp/terraform-ls#558

@dbanck dbanck self-assigned this Apr 1, 2022
@dbanck dbanck force-pushed the f-goto-local-module-source branch 3 times, most recently from c72951a to 37d0e87 Compare April 5, 2022 12:01
@dbanck dbanck changed the title Make use of the LinksTo body schema field for modules Make use of the Targets body schema field for modules Apr 5, 2022
@dbanck dbanck force-pushed the f-goto-local-module-source branch 2 times, most recently from eb60b2c to 6abad45 Compare April 5, 2022 13:27
@dbanck dbanck added the enhancement New feature or request label Apr 5, 2022
@dbanck dbanck marked this pull request as ready for review April 5, 2022 13:29
@dbanck dbanck requested a review from a team April 5, 2022 13:29
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor naming suggestion - otherwise LGTM.

module/meta.go Outdated Show resolved Hide resolved
schema/module_schema.go Outdated Show resolved Hide resolved
@dbanck dbanck force-pushed the f-goto-local-module-source branch from 6abad45 to 40b4520 Compare April 6, 2022 12:19
@dbanck dbanck requested a review from radeksimko April 6, 2022 12:21
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀

@dbanck dbanck merged commit d31af62 into main Apr 6, 2022
@dbanck dbanck deleted the f-goto-local-module-source branch April 6, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants