Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for expressions #19

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Add initial support for expressions #19

merged 1 commit into from
Feb 25, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 19, 2021

Depends on hashicorp/hcl-lang#16


This PR mostly leverages the expression supported introduced in the mentioned upstream PR, which in turn allows us to express the schema more accurately and replace many/most of the ambiguous cty.DynamicPseudoType occurrences.

@radeksimko radeksimko force-pushed the f-expressions branch 4 times, most recently from f1e5742 to 1a41319 Compare February 23, 2021 14:04
@radeksimko radeksimko marked this pull request as ready for review February 23, 2021 14:22
@radeksimko radeksimko added the enhancement New feature or request label Feb 23, 2021
@radeksimko radeksimko requested a review from a team February 23, 2021 15:12
Copy link

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit ef7973c into main Feb 25, 2021
@radeksimko radeksimko deleted the f-expressions branch February 25, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants