Add functions for Terraform 1.8 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
approved these changes
Apr 5, 2024
Co-authored-by: James Pogran <jpogran@outlook.com>
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new functions for Terraform 1.8
It also starts skipping functions prefixed with
core::as Terraform 1.8 started returning all functions twice. Once with and once without the prefix.I thought about filtering at a later stage or in
hcl-lang, however it seemed overly complicated to add a feature tohcl-langwhich allows certain filtering to happen (in order to not leak the Terraform specificcore::prefix filtering to all hcl based languages).Happy to move the filtering e.g. to the schema merging instead, but it seemed the most simple and expected to just tackle it at the source. However, I don't know whether these generated bindings are used for some kind of validations (yet?) so, maybe moving it "up" makes sense – please tell me if that's the case!