Skip to content

Commit

Permalink
provider/aws: Prevent aws_dms_replication_task panic (#12539)
Browse files Browse the repository at this point in the history
Fixes: #12506

When a replication_task cdc_start_time was specified as an int, it was
causing a panic as the conversion to a Unix timestampe was expecting a
string

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAwsDmsReplicationTaskBasic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/08 22:55:29 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAwsDmsReplicationTaskBasic -timeout 120m
=== RUN   TestAccAwsDmsReplicationTaskBasic
--- PASS: TestAccAwsDmsReplicationTaskBasic (1089.77s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	1089.802s
```
  • Loading branch information
stack72 committed Mar 8, 2017
1 parent bb4c075 commit 3e9d446
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion builtin/providers/aws/resource_aws_dms_replication_task.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func resourceAwsDmsReplicationTask() *schema.Resource {

Schema: map[string]*schema.Schema{
"cdc_start_time": {
Type: schema.TypeInt,
Type: schema.TypeString,
Optional: true,
// Requires a Unix timestamp in seconds. Example 1484346880
},
Expand Down

0 comments on commit 3e9d446

Please sign in to comment.