Skip to content

Commit

Permalink
provider/openstack: Don't default 'shared' value, instead only set if…
Browse files Browse the repository at this point in the history
… specified.

Documentation updated to reflect removal of default value.
Fixes #9829
  • Loading branch information
fatmcgav committed Nov 3, 2016
1 parent 6c801d0 commit 4438441
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func resourceFWPolicyV1() *schema.Resource {
"shared": &schema.Schema{
Type: schema.TypeBool,
Optional: true,
Default: false,
},
"tenant_id": &schema.Schema{
Type: schema.TypeString,
Expand Down Expand Up @@ -79,17 +78,20 @@ func resourceFWPolicyV1Create(d *schema.ResourceData, meta interface{}) error {
}

audited := d.Get("audited").(bool)
shared := d.Get("shared").(bool)

opts := policies.CreateOpts{
Name: d.Get("name").(string),
Description: d.Get("description").(string),
Audited: &audited,
Shared: &shared,
TenantID: d.Get("tenant_id").(string),
Rules: rules,
}

if r, ok := d.GetOk("shared"); ok {
shared := r.(bool)
opts.Shared = &shared
}

log.Printf("[DEBUG] Create firewall policy: %#v", opts)

policy, err := policies.Create(networkingClient, opts).Extract()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ The following arguments are supported:
firewall policy.

* `shared` - (Optional) Sharing status of the firewall policy (must be "true"
or "false" if provided - defaults to "false"). If this is "true" the policy
is visible to, and can be used in, firewalls in other tenants. Changing this
updates the `shared` status of an existing firewall policy.
or "false" if provided). If this is "true" the policy is visible to, and
can be used in, firewalls in other tenants. Changing this updates the
`shared` status of an existing firewall policy.

## Attributes Reference

Expand Down

0 comments on commit 4438441

Please sign in to comment.