Skip to content

Commit

Permalink
providers/google: make projects importable.
Browse files Browse the repository at this point in the history
This change doesn't make much sense now, as projects are read-only
anyways, so there's not a lot that importing really does for you--you
can already reference pre-existing projects just by defining them in
your config.

But as we discussed #10425, this change made more and more sense. In a
world where projects can be created, we can no longer reference
pre-existing projects just by defining them in config. We get that
ability back by making projects importable.
  • Loading branch information
paddycarver committed Dec 1, 2016
1 parent 973a46c commit 7054fdf
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 0 deletions.
29 changes: 29 additions & 0 deletions builtin/providers/google/import_google_project_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package google

import (
"fmt"
"testing"

"github.com/hashicorp/terraform/helper/resource"
)

func TestAccGoogleProject_importBasic(t *testing.T) {
resourceName := "google_project.acceptance"
conf := fmt.Sprintf(testAccGoogleProject_basic, projectId)

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
Steps: []resource.TestStep{
resource.TestStep{
Config: conf,
},

resource.TestStep{
ResourceName: resourceName,
ImportState: true,
ImportStateVerify: true,
},
},
})
}
3 changes: 3 additions & 0 deletions builtin/providers/google/resource_google_project.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ func resourceGoogleProject() *schema.Resource {
Read: resourceGoogleProjectRead,
Update: resourceGoogleProjectUpdate,
Delete: resourceGoogleProjectDelete,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},

Schema: map[string]*schema.Schema{
"id": &schema.Schema{
Expand Down
1 change: 1 addition & 0 deletions website/source/docs/import/importability.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ To make a resource importable, please see the
* google_compute_instance_group_manager
* google_compute_instance_template
* google_compute_target_pool
* google_project

### OpenStack

Expand Down

0 comments on commit 7054fdf

Please sign in to comment.