provider/openstack: Fix Ordering of Port Allowed Address Pairs #10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes allowed_address_pairs from a TypeList to a TypeSet allowing for arbitrary ordering. This solves the issue where a user specifies an address pair one way and OpenStack returns a different order.
|
Hey @jtopjian Are there any backwards incompatibilities with this change? P. |
|
@stack72 Nope. This should be transparent to users. I actually forgot about this one. If the code looks good to you, it's good to go. :) |
|
LGTM then :) Thanks! |
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
…corp#10250) This commit changes allowed_address_pairs from a TypeList to a TypeSet allowing for arbitrary ordering. This solves the issue where a user specifies an address pair one way and OpenStack returns a different order.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes allowed_address_pairs from a TypeList to a TypeSet
allowing for arbitrary ordering. This solves the issue where a user
specifies an address pair one way and OpenStack returns a different
order.
Fixes #9680
Side note: while this resolves the above issue, I suspect a better longer-term solution is to create a dedicated resource for allowed address pairs. This will allow more flexible/dynamic creation of port pairs.